Move character width functions to Character class
ClosedPublic

Authored by mglb on Sep 26 2018, 12:52 AM.

Details

Summary

Replaces direct konsole_wcwidth() calls with Character object property
and the class static function, which internally still use
konsole_wcwidth().

The change also prepares the codebase for a new code for determining
character width. This way the change will barely touch existing code.

CCBUG: 396435

Test Plan

konsole_wcwidth() is still used, just in one central place. Passed
compilation and CharacterWidthTest should be enough.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb requested review of this revision.Sep 26 2018, 12:52 AM
mglb created this revision.
hindenburg accepted this revision.Sep 27 2018, 2:45 AM
hindenburg added a subscriber: hindenburg.

LGTM thanks for continuing to work on this

This revision is now accepted and ready to land.Sep 27 2018, 2:45 AM
This revision was automatically updated to reflect the committed changes.