Differential D15751

Center content & banner
ClosedPublic
Actions

Authored by xyquadrat on Sep 25 2018, 7:19 PM.

Details

Reviewers
drosca
Group Reviewers
Falkon
Commits
R1042:b094294ace58: Center content & banner
Summary

The content on the front page is now centered, which IMO improves the look of the site. If anybody disagrees I have no problem abandoning this patch, but it was so simple that I just quickly did it.

Before:

After:

Test Plan

Works nicely on mobile, all content remains accesible

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3210
Build 3228: arc lint + arc unit
xyquadrat requested review of this revision.Sep 25 2018, 7:19 PM
xyquadrat created this revision.
xyquadrat edited the summary of this revision. (Show Details)Sep 25 2018, 7:20 PM
SGOrava added a subscriber: SGOrava.Sep 25 2018, 7:31 PM

It might be good to also adjust items in top menubar.

drosca added a subscriber: drosca.Sep 26 2018, 2:48 PM

Can you please also upload screenshot of page with blog post? Like https://www.falkon.org/2018/05/08/falkon-301-released/

xyquadrat added a comment.Sep 26 2018, 8:18 PM

@drosca Picture of a blog page:

If we'd center the navigation as well, it would look similar to this (only a quick hack, not accurately centered):

I do not have a strong preference about centering the navigation or not, so I'll just implement what the majority wants.

drosca accepted this revision.Sep 27 2018, 7:43 AM

Centered navigation looks bad.

Thanks for the patch.

This revision is now accepted and ready to land.Sep 27 2018, 7:43 AM
drosca closed this revision.Sep 27 2018, 7:49 AM

It's now live at falkon.org

Revision Contents
Changeset List

PathPackages
M_layouts/default.html (6 lines)
M_layouts/post.html (4 lines)
Mindex.html (6 lines)

Diff 42321

View Options

_layouts/default.html

Loading...
View Options

_layouts/post.html

Loading...
View Options

index.html

Loading...