Implement Media API including autotests and additional test: mediaendpointconnector
Details
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Looks good apart from the coding style.
Also it would be great to have at least basic autotest.
src/media.h | ||
---|---|---|
96 | Not needed | |
src/media_p.h | ||
43 | = nullptr | |
44 | Same as above | |
src/mediaendpoint.h | ||
84 | Coding style: const QString &transportObjectPath | |
115 | Not needed | |
src/mediaendpoint_p.h | ||
38 | typo "namepsace" -> "namespace" |
src/media_p.h | ||
---|---|---|
36 | Why? This class is not exported by default, afaik it is only needed if MediaPrivate was declared inside Media class (eg. Media::MediaPrivate), which it is not. |
src/media_p.h | ||
---|---|---|
38 | MediaPrivate will later act as parent for child objects (inheriting QObject). |
src/media_p.h | ||
---|---|---|
38 | Then just parent them to Media instead of private class. |
src/manager_p.cpp | ||
---|---|---|
46 | No need because it is smart pointer. | |
162 | As it is smart pointer, it must not have a parent. | |
src/mediaendpoint.cpp | ||
46 | const QVariantMap & | |
74 | Remove commented code. Also coding style: if (..) { // braces always, even for one statement .. } else if { ... } | |
src/mediaendpoint.h | ||
141 | const QVariantMap &properties |
Alright, last thing:
Why NoInputNoOutputAgent? That should be implemented by the application, and not be part of library. In almost all cases you actually want to inform user that something is trying to connect anyway.
Yes, i also thought this should be application specific. However, i could not imagine another use case of a NoInputNoOutputAgent, except from doing auto connecting to a limited set of UUIDs. So, i thought it is generic enough to be part of the library.
Well, in any case it has nothing to do being included in this commit. So please take it out, and create a separate revision if you want and we can discuss it there.
You're welcome. It's been a pleasure to contribute to this lib.
Manuel Weichselbaumer, mincequi@web.de