Fix spelling errors
ClosedPublic

Authored by borispek on Sep 23 2018, 9:33 PM.

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
borispek created this revision.Sep 23 2018, 9:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 23 2018, 9:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
borispek requested review of this revision.Sep 23 2018, 9:33 PM
ngraham accepted this revision.Sep 23 2018, 9:49 PM

Whoops! Thanks for fixing those.

I'd like to land this for you, but to do it, I'll need to know your real name and email address. Can you provide that information? Thanks!

This revision is now accepted and ready to land.Sep 23 2018, 9:49 PM

Hi,

I'll need to know your real name and email address. Can you provide that information?

Boris Pek <tehnick-8@yandex.ru>

I supposed that all necessary information was in the patch prepared using git format-patch .... It looks I have missed something in phabricator documentation. (This is my first patch to KDE after a huge break...)

Hi,

I'll need to know your real name and email address. Can you provide that information?

Boris Pek <tehnick-8@yandex.ru>

I supposed that all necessary information was in the patch prepared using git format-patch .... It looks I have missed something in phabricator documentation. (This is my first patch to KDE after a huge break...)

Sadly not, just yet; right now we only get that automatically if you use the arc command-line tool to create the patch. See https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

It's good to have you back!

This revision was automatically updated to reflect the committed changes.

Landed on master, so the change will show up in KDE Plasma 5.15. See https://community.kde.org/Schedules/Plasma_5 for more information.

Landed on master, so the change will show up in KDE Plasma 5.15. See https://community.kde.org/Schedules/Plasma_5 for more information.

Why not in 5.14 which also has these errors?

Because it has a string change, but I realize now that this doesn't actually preclude going into 5.14 since it's not a translated string. I'll cherry-pick it onto 5.14, and thanks for following up on this @rikmills!

Cherry-picked onto the Plasma/5.14 branch now.