Details
Diff Detail
- Repository
- R99 KDE Gtk Configuration Tool
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Whoops! Thanks for fixing those.
I'd like to land this for you, but to do it, I'll need to know your real name and email address. Can you provide that information? Thanks!
Hi,
I'll need to know your real name and email address. Can you provide that information?
Boris Pek <tehnick-8@yandex.ru>
I supposed that all necessary information was in the patch prepared using git format-patch .... It looks I have missed something in phabricator documentation. (This is my first patch to KDE after a huge break...)
Sadly not, just yet; right now we only get that automatically if you use the arc command-line tool to create the patch. See https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist
It's good to have you back!
Landed on master, so the change will show up in KDE Plasma 5.15. See https://community.kde.org/Schedules/Plasma_5 for more information.
Because it has a string change, but I realize now that this doesn't actually preclude going into 5.14 since it's not a translated string. I'll cherry-pick it onto 5.14, and thanks for following up on this @rikmills!