Differential D15709

[effects/morphingpopups] Use enumerators from the DataRole enum
ClosedPublic
Actions

Authored by zzag on Sep 23 2018, 1:54 PM.

Details

Reviewers
broulik
Group Reviewers
KWin
Commits
R108:646032a99d93: [effects/morphingpopups] Use enumerators from the DataRole enum
Summary

Use Effect.WindowForceBackgroundContrastRole and Effect.WindowForceBlurRole
instead of integers to improve readability.

Diff Detail

Repository
R108 KWin
Branch
effects-morphingpopups-explicit-force-role
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3152
Build 3170: arc lint + arc unit
zzag created this revision.Sep 23 2018, 1:54 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 23 2018, 1:54 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 23 2018, 1:54 PM
broulik accepted this revision.Sep 24 2018, 11:52 AM
This revision is now accepted and ready to land.Sep 24 2018, 11:52 AM
Closed by commit R108:646032a99d93: [effects/morphingpopups] Use enumerators from the DataRole enum (authored by zzag). · Explain WhySep 24 2018, 12:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42185

View Options

effects/morphingpopups/package/contents/code/morphingpopups.js

Loading...