| davidedmundson |
| KWin |
The "Force" part in WindowForceBackgroundContrastRole and WindowForceBlurRole
is confusing. If WindowForceBlurRole is set on a window, background
behind it won't be blurred.
By setting WindowForceBlurRole we tell the Blur effect "that's fine to
do your business behind transformed windows."
The Slide effect only translates windows, it doesn't distort them, etc.
So, we can set WindowForceBackgroundContrastRole and WindowForceBlurRole
for all windows.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
The "Force" part in WindowForceBackgroundContrastRole and WindowForceBlurRole is confusing.
It really is.
I don't understand why we still do
if ((scaled || (translated || (mask & PAINT_WINDOW_TRANSFORMED))) && !w->data(WindowForceBlurRole).toBool())
in blur given blur now supports both translation and scaling.
I think we can kill that (leaving the mask check for coverswitch) and then remove all the force stuff from this effect.
Does that make sense?
| effects/slide/slide.cpp | ||
|---|---|---|
| 394–395 | Do we need to call this from the dtor in case the effect is unloaded whilst we're active? Not implausible if the user closes the "do you want to apply settings" prompt in kwin system settings. | |
I agree, but I think we still need "force" roles. (to support third party full screen effects)
| effects/slide/slide.cpp | ||
|---|---|---|
| 394–395 | Hmm, yeah, maybe. | |
I agree, but I think we still need "force" roles. (to support third party full screen effects)
Cool, I'll give it a go