DateTime Runner timezone and 24 hour clock time conversion.
Needs ReviewPublic

Authored by smithjd on Sep 21 2018, 8:49 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Summary

Convert time to and from other time zones. Report time in 24 hr time.

Diff Detail

Repository
R114 Plasma Addons
Branch
master-timeconverter (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5409
Build 5427: arc lint + arc unit
smithjd created this revision.Sep 21 2018, 8:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 21 2018, 8:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
smithjd requested review of this revision.Sep 21 2018, 8:49 PM
smithjd updated this revision to Diff 42274.Sep 24 2018, 10:25 PM
  • [DateTime Runner] Add two new syntaxes for conversion to and from 24 hour time.
smithjd updated this revision to Diff 43091.Oct 7 2018, 10:31 PM
  • [DateTime Runner] Show a date match if needed on conversion both to and from local
mart accepted this revision.Nov 23 2018, 2:23 PM
This revision is now accepted and ready to land.Nov 23 2018, 2:23 PM
smithjd updated this revision to Diff 46297.Nov 27 2018, 4:27 AM

Rebase around multiple zone matching, and some improvements.

smithjd requested review of this revision.Nov 27 2018, 4:28 AM
smithjd updated this revision to Diff 49976.Jan 20 2019, 11:48 PM
  • [DateTime Runner] Add from-zone, to-zone and 24-hour time conversion. Improve timezone lookups (i.e. identical zone names now return all matches). The zone name is now used instead of the abbreviation in matches.
  • Rebase to current master.

Some screenshots would be helpful here.

smithjd added a comment.EditedJan 22 2019, 12:00 AM

Timezone name expansion, date into the future, and multiple matches:

24-hr conversion, date and multiple matches:

Timezone name expansion, date into the future, and multiple matches:

In general +1, but I think we'll get bug reports over the elided text, which is a regression compared to the current output of time Australia. Can you think of anything we can do about that?

24-hr conversion, date and multiple matches:

+1