Differential D15683

Add lock icon to desktop context menu
ClosedPublic
Actions

Authored by anemeth on Sep 21 2018, 6:18 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Commits
R119:c4dbf66fe135: Merge branch 'Plasma/5.14'
R119:a5e45788fa33: Add lock icon to desktop context menu
Summary

Having only one icon in the whole menu seemed a waste of space.
Adding a lock icon to the lock function greatly improves the scene.

Test Plan

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3104
Build 3122: arc lint + arc unit
anemeth created this revision.Sep 21 2018, 6:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 21 2018, 6:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anemeth requested review of this revision.Sep 21 2018, 6:18 PM
anemeth edited the summary of this revision. (Show Details)Sep 21 2018, 6:20 PM
anemeth edited the test plan for this revision. (Show Details)
anemeth added reviewers: ngraham, VDG.
anemeth retitled this revision from Add lock icon to context menu to Add lock icon to desktop context menu.
ngraham accepted this revision.Sep 21 2018, 6:46 PM

LGTM!

This revision is now accepted and ready to land.Sep 21 2018, 6:46 PM
anemeth added a comment.Sep 21 2018, 8:11 PM

My arcanist is still borked. Could someone please push this? Thank you.

safaalfulaij added a subscriber: safaalfulaij.Sep 21 2018, 8:52 PM

Why not also add icons to other items instead of other X number of commits coming later by Y number of people?
Yes, some don't have “group” icon (like sort, where only ascending and descending are available), but I don't see a problem if we used any “child” one as “group”, like ascending for sorting, center for alignement, etc.

ngraham added a comment.Sep 22 2018, 3:40 PM
In D15683#329959, @safaalfulaij wrote:

Why not also add icons to other items instead of other X number of commits coming later by Y number of people?
Yes, some don't have “group” icon (like sort, where only ascending and descending are available), but I don't see a problem if we used any “child” one as “group”, like ascending for sorting, center for alignement, etc.

Sounds like a good task for you, since you've taken an interest. ;)

ngraham closed this revision.Sep 22 2018, 3:40 PM

Revision Contents
Changeset List

Diff 42107

View Options

containments/desktop/plugins/folder/viewpropertiesmenu.cpp

Loading...