[Comic] Handle error state correctly
ClosedPublic

Authored by anthonyfieroni on Sep 20 2018, 11:09 AM.

Details

Summary

This happen really rare, i've used comic applet on my desktop about years, but in such cases dataUpdated is not called and busy indicator *burns* cpu. So i provide possible fix in comic provider, data engine, when redirection is needed error timer is not restarted in such case error is never handle properly. But *every* case i made a more aggressive solution, a timer in comic applet, if in 3 minutes dataUpdated isn't called it just force disconnect engine from source and stops indicator.

CCBUG: 363292

Diff Detail

Repository
R114 Plasma Addons
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: Plasma. · View Herald TranscriptSep 20 2018, 11:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Sep 20 2018, 11:10 AM
anthonyfieroni updated this revision to Diff 41977.

Another approach: If timer expires in 2 min without result disconnect it from source and starts again for next 2 min, when it expires if try to update again by activate slotCurrentDay

Stop indicator in a minute, restart engine in 10 sec.

Ping, @davidedmundson let's make some change on this

davidedmundson requested changes to this revision.Oct 12 2018, 12:26 PM

but in such cases dataUpdated is not called

In what cases?

The DataEngine also has a timer for timeouts, so we now have two timeout timers.
Having two timeout timers doesn't seem right.

This revision now requires changes to proceed.Oct 12 2018, 12:26 PM

The DataEngine also has a timer for timeouts, so we now have two timeout timers.
Having two timeout timers doesn't seem right.

Yep, i'm on same opinion, it looks like i some cases timer in DataEngine is not started. One possible case what i provide in ComicProvider::requestRedirectedUrl, i don't see other cases where dataUpdated isn't called. mRestartEngine timer is in "any case".

yeah, that change in comicprovider I think makes sense.

@davidedmundson to commit or you have other objections?

davidedmundson accepted this revision.Oct 24 2018, 9:48 AM
This revision is now accepted and ready to land.Oct 24 2018, 9:48 AM
This revision was automatically updated to reflect the committed changes.