Add "Create Folder" action to default toolbar
AbandonedPublic

Authored by ngraham on Sep 19 2018, 11:10 PM.

Details

Reviewers
None
Group Reviewers
Dolphin
VDG
Summary

Some of the most common organizational tasks for a typical user start with creating a new folder. We should make that easy and obvious by putting a button for it in the toolbar.

Test Plan

Diff Detail

Repository
R318 Dolphin
Branch
new-folder-in-toolbar (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3018
Build 3036: arc lint + arc unit
ngraham created this revision.Sep 19 2018, 11:10 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSep 19 2018, 11:10 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 19 2018, 11:10 PM
ngraham edited the test plan for this revision. (Show Details)Sep 19 2018, 11:11 PM

-1 to cluttering Dolphin's toolbar

Do you have any base for your "common task" claim? Next we'll get a "Show hidden files", "Terminal", "Delete" button.......

I would rather like to see a "contextual" sub toolbar below the address bar showing tasks related to the current view and/or selected item(s) like Windows Explorer has it. There we could also place the "Empty Trash" button inside Trash.

abetts added a subscriber: abetts.Sep 20 2018, 1:58 PM

Maybe the amount of buttons is not really the issue, if they didn't have labels by default, we would have a lot more room. Thoughts?

ngraham abandoned this revision.Sep 20 2018, 2:39 PM

Maybe the amount of buttons is not really the issue, if they didn't have labels by default, we would have a lot more room. Thoughts?

True, but buttons without labels have worse usability--especially when they don't look like buttons until you hover over them, as is the case for ours.

I would rather like to see a "contextual" sub toolbar below the address bar showing tasks related to the current view and/or selected item(s) like Windows Explorer has it. There we could also place the "Empty Trash" button inside Trash.

Strongly agree. Alas I think that is a bit beyond my programming abilities at this point. I would like to see such a thing anywhere icons/items can be selected--File dialogs, Gwenview, Folder View, etc. This would also make these views super touch friendly and improve usability for the default single-click setting. See T8187#132928 and T8187#139062. The GNOME folks are considering doing this for Nautilus, but I think ours could be even better.

Should we abandon this effort and focus on that?