Differential D15593

Split out notificator to allow for testing plus tests
ClosedPublic
Actions

Authored by dklimkin on Sep 18 2018, 6:41 PM.

Details

Reviewers

aacid

Commits

R368:006910d73a03: Split out notificator to allow for testing plus tests

Diff Detail

Repository

R368 RSIBreak

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dklimkin requested review of this revision.Sep 18 2018, 6:41 PM

dklimkin created this revision.

The patch doesn't seem to apply here, is this on top of master?

Hunk #2 succeeded at 39 with fuzz 2 (offset -1 lines).
Hunk #3 FAILED at 88.
Hunk #4 succeeded at 171 with fuzz 2 (offset 2 lines).
Hunk #5 FAILED at 194.
Hunk #6 succeeded at 290 with fuzz 2 (offset 6 lines).
Hunk #7 succeeded at 304 (offset 6 lines).
Hunk #8 FAILED at 321.
Hunk #9 succeeded at 336 with fuzz 2 (offset 7 lines).
Hunk #10 FAILED at 377.
4 out of 10 hunks FAILED -- saving rejects to file test/rsitimer_test.cpp.rej

test/rsitimer_test.cpp
335	Please use the "new style" way of defining signal connections and not the SIGNAL() one

ah my fault was based on the other revision

aacid added inline comments.Oct 8 2018, 9:09 PM

test/rsitimer_test.cpp
335	meh whatever, i guess test will fail if the connect breaks

This revision was not accepted when it landed; it landed in state Needs Review.Oct 8 2018, 9:12 PM

Closed by commit R368:006910d73a03: Split out notificator to allow for testing plus tests (authored by dklimkin, committed by aacid). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (1 line)
A	M	src/notificator.h (42 lines)
A	M	src/notificator.cpp (56 lines)
M		src/rsiglobals.cpp (14 lines)
M		src/rsitimer.h (8 lines)
M		src/rsitimer.cpp (13 lines)
M		src/rsiwidget.h (4 lines)
M		src/rsiwidget.cpp (12 lines)
M		test/rsitimer_test.cpp (18 lines)