Adjust tests to proper handle ownership
ClosedPublic
Actions

Authored by dklimkin on Sep 18 2018, 6:40 PM.

Details

Reviewers

aacid

Commits

R368:fae094876050: Adjust tests to proper handle ownership

Repository

R368 RSIBreak

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dklimkin requested review of this revision.Sep 18 2018, 6:40 PM

dklimkin created this revision.

src/rsitimer.h
203	Are you sure this patch is fine? Here you remove the const from the _intervals vector but in the .cpp it's still there

dklimkin marked an inline comment as done.Sep 21 2018, 5:14 PM

dklimkin added inline comments.

src/rsitimer.h
203	the tests pass. const has not effect for value parameters in function declarations.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 8 2018, 9:05 PM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41909			Sep 18 2018, 6:38 PM	★	★
Diff 2	43168	82be553	R368:fae09487605050ba8e3dd2d13557a5e875624d49	Oct 8 2018, 9:03 PM	★	★