Differential D15578

[Notifications] Store "Open..." action in history
ClosedPublic
Actions

Authored by broulik on Sep 17 2018, 2:37 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:a8b71fe5c017: [Notifications] Store "Open..." action in history
Summary

Actions stop working when the original notification goes away, however the "Open..." notification when a job completed is added and handled by us, so we can store it in the history and it will continue to function.

BUG: 398732
FIXED-IN: 5.14.0

Test Plan
  • Copied a file, finished, the notification in the history had an "Open" button that worked
  • Tested some other notifications, their actions were all removed

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 17 2018, 2:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 17 2018, 2:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 17 2018, 2:37 PM
davidedmundson accepted this revision.Sep 17 2018, 4:03 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
applets/notifications/package/contents/ui/Notifications.qml
95

eww.

I hope it's not like this after the refactor

This revision is now accepted and ready to land.Sep 17 2018, 4:03 PM
Closed by commit R120:a8b71fe5c017: [Notifications] Store "Open..." action in history (authored by broulik). · Explain WhySep 17 2018, 4:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41854

View Options

applets/notifications/package/contents/ui/Notifications.qml

Loading...