Details
- Reviewers
tcanabrava - Group Reviewers
KDE Edu
Diff Detail
- Repository
- R332 Kiten
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2960 Build 2978: arc lint + arc unit
| kanjibrowser/kanjibrowserview.cpp | ||
|---|---|---|
| 181 | this test is strange. | |
The commit log seems a bit strange, it says "Remove warnings by replacing deprecated methods", but i don't see [almost] any method replaced, it's mostly 0 -> nullptr and some static_cast to qobject_cast.
Can you explain the reason for the static_cast->qobject_cast change?
| .gitignore | ||
|---|---|---|
| 1 | We don't usually add .gitignore files to repos as far as i remember | |
I can revert the git ignore thing.
I Belive I messed up on squashing his commits as I was called to help him
fixing a bad rebase.
If you want I can do a followup commit fixing those issues.
Em ter, 18 de set de 2018 às 19:42, Albert Astals Cid <
noreply@phabricator.kde.org> escreveu:
aacid added a comment. View Revision https://phabricator.kde.org/D15575
The commit log seems a bit strange, it says "Remove warnings by replacing
deprecated methods", but i don't see [almost] any method replaced, it's
mostly 0 -> nullptr and some static_cast to qobject_cast.Can you explain the reason for the static_cast->qobject_cast change?
*INLINE COMMENTS*
View Inline https://phabricator.kde.org/D15575#inline-84092.gitignore:1
CMakeLists.txt.userWe don't usually add .gitignore files to repos as far as i remember
*REPOSITORY*
R332 Kiten*REVISION DETAIL*
https://phabricator.kde.org/D15575*To: *vallim, tcanabrava, KDE Edu
*Cc: *aacid, kde-edu, narvaez, apol