Differential D1557

Add CMake option to compile breeze icons as Qt resource.
AbandonedPublic
Actions

Authored by arrowd on May 8 2016, 10:58 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Maniphest Tasks
T1775: Windows: Create icon resource file
Summary

This would ask user for the directory containing breeze-icons repo clone. It would then generate .qrc file out of the icons/ subdir and then make up a .rcc binary resource.

This is all it does ATM, as i have no idea what should be done on the code side.

Diff Detail

Repository
R32 KDevelop
Branch
icons_resource (branched from 5.0)
Lint
No Linters Available
Unit
No Unit Test Coverage
arrowd updated this revision to Diff 3692.May 8 2016, 10:58 AM
arrowd retitled this revision from to Add CMake option to compile breeze icons as Qt resource..
arrowd updated this object.
arrowd edited the test plan for this revision. (Show Details)
arrowd added reviewers: KDevelop, kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 8 2016, 10:58 AM
brauch added a subscriber: brauch.May 8 2016, 11:53 AM

Looks cool to me. The choice of default dir (with the R:\) is a bit strange, but I guess it's simple enough to change it.

apol added a subscriber: apol.May 9 2016, 1:04 AM

Could we move this code into breeze-icons? I know for a fact other projects want to do similar things.

Breeze Icons is a framework nowadays, after all.

kfunk requested changes to this revision.May 9 2016, 6:30 AM
kfunk edited edge metadata.
In D1557#28976, @apol wrote:

Could we move this code into breeze-icons? I know for a fact other projects want to do similar things.

Breeze Icons is a framework nowadays, after all.

+1. I also think this code should be close to the icon set, so others can reuse.

Thanks for working on it, Gleb.

This revision now requires changes to proceed.May 9 2016, 6:30 AM

Revision Contents
Changeset List

PathPackages
Mapp/CMakeLists.txt (37 lines)

Diff 3692

View Options

app/CMakeLists.txt

Loading...