Differential D15568

Fix finding QtQuick
ClosedPublic
Actions

Authored by broulik on Sep 17 2018, 7:52 AM.

Details

Reviewers
ntninja
hpereiradacosta
Group Reviewers
Plasma
Commits
R31:3e8eac8fc461: Fix finding QtQuick
Summary

It is QtQuick_FOUND, not Qt_Quick_FOUND. This broke all special-casings for QtQuick, such as "drag on empty area" in QtQuick windows and ComboBox popups.

BUG: 398663
FIXED-IN: 5.14.0

Test Plan

Compiles. QtQuick Controls 1 Dropdowns are fine again in Breeze Dark and dragging e.g. wallpaper dialog on empty area works again

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 17 2018, 7:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 17 2018, 7:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 17 2018, 7:52 AM
broulik added a reviewer: hpereiradacosta.
hpereiradacosta accepted this revision.Sep 17 2018, 8:05 AM

Thanks for tracking this down !

This revision is now accepted and ready to land.Sep 17 2018, 8:05 AM
Closed by commit R31:3e8eac8fc461: Fix finding QtQuick (authored by broulik). · Explain WhySep 17 2018, 8:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkstyle/CMakeLists.txt (4 lines)

Diff 41799

View Options

kstyle/CMakeLists.txt

Loading...