Python bindings: use cmake_parse_arguments, fix documentation
ClosedPublic

Authored by bruns on Sep 16 2018, 7:46 PM.

Details

Summary

Use of positional arguments is error prone, as e.g. switching order
of NAMESPACE and MODULENAME wont have the desired effect, as
the keywords are ignored for the first three arguments.

Parse all arguments with cmake_parse_arguments, and fix the documentation
(list supported arguments) and example (add TARGET keyword).

Test Plan

build bindings

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Sep 16 2018, 7:46 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptSep 16 2018, 7:46 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Sep 16 2018, 7:46 PM
bruns retitled this revision from Python bindings: use cmake_parse_arguements, fix documentation to Python bindings: use cmake_parse_arguments, fix documentation.Sep 19 2018, 9:16 PM
bruns edited the summary of this revision. (Show Details)
bruns updated this revision to Diff 41952.Sep 19 2018, 11:14 PM

Fix parentheses

dfaure accepted this revision.Sep 20 2018, 7:29 AM

This is technically not 100% source compatible, but since the callers were already passing "TARGET" (and others) as documented, I guess it's fine.

This revision is now accepted and ready to land.Sep 20 2018, 7:29 AM
This revision was automatically updated to reflect the committed changes.