Fix: Email highlighting for unclosed parenthesis in Subject header
ClosedPublic
Actions

Authored by dhaumann on Sep 16 2018, 6:05 PM.

Details

Reviewers

Commits

R216:b1da54ab91e3: Fix: Email highlighting for unclosed parenthesis in Subject header

Summary

Unfortunately, the "Subject:" header needs to be treated independently
of the other headers, since it may contain arbitrary text such as paranthesis
that is not a comment or similar. The fix is to add another context without
the comment highlighting.

BUG: 398717

Test Plan

make test

Diff Detail

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dhaumann created this revision.Sep 16 2018, 6:05 PM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 16 2018, 6:05 PM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

dhaumann requested review of this revision.Sep 16 2018, 6:05 PM

Harbormaster completed remote builds in B2930: Diff 41763.Sep 16 2018, 6:05 PM

vkrause accepted this revision.Sep 16 2018, 6:08 PM

This revision is now accepted and ready to land.Sep 16 2018, 6:08 PM

Closed by commit R216:b1da54ab91e3: Fix: Email highlighting for unclosed parenthesis in Subject header (authored by dhaumann). · Explain WhySep 16 2018, 6:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/folding/test.eml.fold (4 lines)
M			autotests/html/test.eml.html (4 lines)
M			autotests/input/test.eml (4 lines)
M			autotests/reference/test.eml.ref (4 lines)
M			data/syntax/email.xml (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41763	d0c6981		Sep 16 2018, 6:05 PM	★	★
Diff 2	41766	d0c6981	R216:b1da54ab91e331fdecbe07a9f40a9c1908143a4b	Sep 16 2018, 6:10 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
bfa0976261cb	625517f20591	d0c698198ec8	Dominik Haumann	Fix: Email highlighting for unclosed parenthesis in Subject header (Show More…)	Sep 16 2018, 6:01 PM