Differential D15549

Words: Save anchor info also for page-anchored shapes
ClosedPublic
Actions

Authored by danders on Sep 16 2018, 8:16 AM.

Details

Reviewers
boemann
Commits
R8:02f34b05723a: Words: Save anchor info also for page-anchored shapes
Summary

LO needs anchor info to position shapes correctly.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders created this revision.Sep 16 2018, 8:16 AM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptSep 16 2018, 8:16 AM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
danders requested review of this revision.Sep 16 2018, 8:16 AM
boemann added a comment.Sep 16 2018, 9:04 AM

Bah I can't remember this, but page anchored shapes don't have anchors as such, so I'm wondering what exactly is this writing to file?

danders added a comment.Sep 17 2018, 6:47 AM

After reading the fine print, see: http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1420028_253892949
it seems to me a shape can be anchored to a page in different ways. Note this:
"If the attribute value is not from-left and not from-inside, the svg:x attribute associated with the frame element is ignored for text documents."
This would explain that LO seems to discard x,y when anchor info is not saved.
Afaics there is no defined default values for anchor values.

boemann accepted this revision.Sep 17 2018, 8:10 AM
This revision is now accepted and ready to land.Sep 17 2018, 8:10 AM
Closed by commit R8:02f34b05723a: Words: Save anchor info also for page-anchored shapes (authored by danders). · Explain WhySep 17 2018, 10:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mwords/part/KWOdfWriter.cpp (4 lines)

Diff 41811

View Options

words/part/KWOdfWriter.cpp

Loading...