Add break; statements in the generated switch code for model::data()
ClosedPublic
Actions

Authored by kossebau on Sep 15 2018, 7:45 PM.

Details

Reviewers

Commits

R881:1ce86bd5d58d: Add break; statements in the generated switch code for model::data()

Summary

Compiler complains about generated code with
warning: this statement may fall through
and is slightly right, as the code might fall through if a role is used
which is not catched for a column.

Diff Detail

Repository

R881 Rust Qt Binding Generator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau requested review of this revision.Sep 15 2018, 7:45 PM

kossebau created this revision.

Harbormaster completed remote builds in B2893: Diff 41710.Sep 15 2018, 7:45 PM

Very good. Weirdly, my compiler did not complain about this.

This revision is now accepted and ready to land.Sep 15 2018, 7:59 PM

Closed by commit R881:1ce86bd5d58d: Add break; statements in the generated switch code for model::data() (authored by kossebau). · Explain WhySep 15 2018, 8:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			demo/src/Bindings.cpp (13 lines)
M			src/cpp.cpp (2 lines)
M			tests/test_list_rust.cpp (2 lines)
M			tests/test_list_types_rust.cpp (1 line)
M			tests/test_tree_rust.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41710	0192124		Sep 15 2018, 7:45 PM	★	★
Diff 2	41711	0192124	R881:1ce86bd5d58d66ea2157db2c8f33f5b2035dd17f	Sep 15 2018, 8:02 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3b6dc043fac7	78fd6eb69c35	0192124c7087	Friedrich W. H. Kossebau	Add break; statements in the generated switch code for model::data() (Show More…)	Sep 15 2018, 7:43 PM