I'm okay with this patch, but please wait with landing it until we've released 4.1.2 so we don't have to cherry-pick patches to the krita/4.1 branch anymore.

This revision is now accepted and ready to land.Sep 15 2018, 8:55 AM

Closed by commit R37:d7d75a8ac3db: Normalize SIGNAL and SLOT signatures (authored by yurchor). · Explain WhySep 27 2018, 3:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libs/command/kundo2model.cpp (2 lines)
M			libs/flake/KoCanvasControllerWidget.cpp (2 lines)
M			libs/flake/KoShapeFactoryBase.cpp (2 lines)
M			libs/flake/KoToolManager.cpp (36 lines)
M			libs/flake/tests/TestResourceManager.cpp (6 lines)
M			libs/global/kis_acyclic_signal_connector.cpp (8 lines)
M			libs/image/kis_image_animation_interface.cpp (4 lines)
M			libs/image/tests/kis_image_signal_router_test.cpp (6 lines)
M			libs/image/tests/kis_keyframing_test.cpp (2 lines)
M			libs/image/tests/kis_processing_applicator_test.cpp (2 lines)
M			libs/libqml/plugins/kritasketchplugin/models/CompositeOpModel.cpp (4 lines)
M			libs/libqml/plugins/kritasketchplugin/models/LayerModel.cpp (18 lines)
M			libs/libqml/plugins/kritasketchplugin/models/PresetModel.cpp (4 lines)
M			libs/ui/KisAutoSaveRecoveryDialog.cpp (2 lines)
M			libs/ui/KisDetailsPane.cpp (8 lines)
M			libs/ui/KisDocument.cpp (12 lines)
M			libs/ui/KisMainWindow.cpp (14 lines)
M			libs/ui/KisNodeView.cpp (4 lines)
M			libs/ui/KisOpenPane.cpp (26 lines)
M			libs/ui/KisReferenceImagesDecoration.cpp (4 lines)
M			libs/ui/KisTemplateCreateDia.cpp (4 lines)
M			libs/ui/KisView.cpp (10 lines)
M			libs/ui/KisViewManager.cpp (4 lines)
M			libs/ui/KisWindowLayoutManager.cpp (4 lines)
M			libs/ui/brushhud/kis_brush_hud.cpp (4 lines)
M			libs/ui/brushhud/kis_uniform_paintop_property_widget.cpp (8 lines)
M			libs/ui/canvas/kis_animation_player.cpp (2 lines)
M			libs/ui/canvas/kis_canvas2.cpp (2 lines)
M			libs/ui/canvas/kis_display_color_converter.cpp (4 lines)
M			libs/ui/canvas/kis_guides_manager.cpp (20 lines)
M			libs/ui/canvas/kis_paintop_transformation_connector.cpp (4 lines)
M			libs/ui/dialogs/kis_dlg_file_layer.cpp (4 lines)
M			libs/ui/dialogs/kis_dlg_stroke_selection_properties.cpp (4 lines)
M			libs/ui/flake/kis_shape_layer_canvas.cpp (2 lines)
M			libs/ui/kis_gui_context_command.cpp (4 lines)
M			libs/ui/kis_node_manager.cpp (10 lines)
M			libs/ui/kis_paintop_settings_widget.cpp (6 lines)
M			libs/ui/kis_popup_palette.cpp (2 lines)
M			libs/ui/kis_stopgradient_editor.cpp (2 lines)
M			libs/ui/tests/kis_derived_resources_test.cpp (2 lines)
M			libs/ui/tool/kis_rectangle_constraint_widget.cpp (12 lines)
M			libs/ui/widgets/KisNewsWidget.cpp (2 lines)
M			libs/ui/widgets/KoFillConfigWidget.cpp (6 lines)
M			libs/ui/widgets/KoStrokeConfigWidget.cpp (4 lines)
M			libs/ui/widgets/kis_paintop_preset_icon_library.cpp (4 lines)
M			libs/ui/widgets/kis_paintop_presets_popup.cpp (2 lines)
M			libs/ui/widgets/kis_scratch_pad.cpp (4 lines)
M			libs/vectorimage/libemf/demo/EmfViewer.cpp (4 lines)
M			libs/widgets/KoColorPopupAction.cpp (6 lines)
M			libs/widgets/KoColorSetWidget.cpp (6 lines)
M			libs/widgets/KoEditColorSetDialog.cpp (4 lines)
M			libs/widgets/KoPageLayoutDialog.cpp (12 lines)
M			libs/widgets/KoPageLayoutWidget.cpp (4 lines)
M			libs/widgets/KoResourceItemChooser.cpp (4 lines)
M			libs/widgets/KoResourceTaggingManager.cpp (16 lines)
M			libs/widgets/KoShadowConfigWidget.cpp (6 lines)
M			libs/widgets/KoStrokeConfigWidget.cpp (6 lines)
M			libs/widgets/KoToolBox.cpp (4 lines)
M			libs/widgets/KoToolDocker.cpp (2 lines)
M			libs/widgets/KoUnitDoubleSpinBox.cpp (2 lines)
M			libs/widgets/KoZoomAction.cpp (4 lines)
M			libs/widgets/KoZoomController.cpp (8 lines)
M			libs/widgets/KoZoomInput.cpp (2 lines)
M			libs/widgets/KoZoomWidget.cpp (2 lines)
M			libs/widgets/kis_double_parse_unit_spin_box.cpp (2 lines)
M			libs/widgets/kis_file_name_requester.cpp (2 lines)
M			plugins/dockers/advancedcolorselector/kis_color_selector.cpp (2 lines)
M			plugins/dockers/advancedcolorselector/kis_color_selector_base.cpp (4 lines)
M			plugins/dockers/advancedcolorselector/kis_common_colors.cpp (6 lines)
M			plugins/dockers/animation/kis_equalizer_widget.cpp (4 lines)
M			plugins/dockers/animation/timeline_frames_view.cpp (10 lines)
M			plugins/dockers/animation/timeline_node_list_keeper.cpp (2 lines)
M			plugins/dockers/artisticcolorselector/artisticcolorselector_dock.cpp (8 lines)
M			plugins/dockers/compositiondocker/compositiondocker_dock.cpp (2 lines)
M			plugins/dockers/defaultdockers/kis_layer_box.cpp (24 lines)
M			plugins/dockers/griddocker/grid_config_widget.cpp (6 lines)
M			plugins/dockers/griddocker/griddocker_dock.cpp (8 lines)
M			plugins/dockers/tasksetdocker/tasksetdocker_dock.cpp (4 lines)
M			plugins/extensions/qmic/QMic.cpp (6 lines)
M			plugins/filters/asccdl/kis_wdg_asccdl.cpp (12 lines)
M			plugins/filters/colors/kis_wdg_color_to_alpha.cpp (8 lines)
M			plugins/filters/fastcolortransfer/kis_wdg_fastcolortransfer.cpp (2 lines)
M			plugins/filters/levelfilter/kis_level_filter.cpp (4 lines)
M			plugins/filters/phongbumpmap/kis_phong_bumpmap_config_widget.cpp (2 lines)
M			plugins/flake/textshape/kotext/OdfTextTrackStyles.cpp (8 lines)
M			plugins/impex/video/video_saver.cpp (2 lines)
M			plugins/paintops/libpaintop/kis_brush_chooser.cpp (10 lines)
M			plugins/paintops/libpaintop/kis_compositeop_option.cpp (2 lines)
M			plugins/paintops/libpaintop/kis_curve_option_widget.cpp (4 lines)
M			plugins/paintops/libpaintop/kis_filter_option.cpp (2 lines)
M			plugins/paintops/libpaintop/kis_multi_sensors_selector.cpp (2 lines)
M			plugins/paintops/libpaintop/kis_text_brush_chooser.cpp (2 lines)
M			plugins/paintops/tangentnormal/kis_tangent_tilt_option.cpp (6 lines)
M			plugins/tools/basictools/kis_tool_multihand.cpp (2 lines)
M			plugins/tools/svgtexttool/SvgTextTool.cpp (2 lines)
M			plugins/tools/tool_lazybrush/kis_tool_lazy_brush_options_widget.cpp (4 lines)
M			plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp (8 lines)