Differential D15519

Privatize variables in InputDeviceHandler
ClosedPublic
Actions

Authored by romangg on Sep 15 2018, 12:41 AM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R108:eab71a8a19b2: Privatize variables in InputDeviceHandler

Summary

Some members were declared protected. Better style is to have them private
with public or protected getters and setters.

This also removes the unnecessary m_input variable.

Test Plan

Builds and runs.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.Sep 15 2018, 12:41 AM

Restricted Application added a project: KWin. · View Herald TranscriptSep 15 2018, 12:41 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

romangg requested review of this revision.Sep 15 2018, 12:41 AM

Harbormaster completed remote builds in B2872: Diff 41676.Sep 15 2018, 12:41 AM

romangg added a dependency: D15502: Float position values in drag input filter.Sep 15 2018, 12:43 AM

davidedmundson accepted this revision.Sep 17 2018, 12:43 PM

This revision is now accepted and ready to land.Sep 17 2018, 12:43 PM

romangg added a dependent revision: D15595: Rework InputDeviceHandler focus tracking.Sep 18 2018, 7:16 PM

Closed by commit R108:eab71a8a19b2: Privatize variables in InputDeviceHandler (authored by romangg). · Explain WhyDec 2 2018, 8:17 PM

This revision was automatically updated to reflect the committed changes.

This revision caused a regression in the autotests. https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/225/testReport/junit/(root)/TestSuite/kwin_testWindowSelection_waylandonly/

Revision Contents
Changeset List

			Path	Packages
M			input.h (12 lines)
M			input.cpp (3 lines)
M			pointer_input.cpp (170 lines)
M			touch_input.cpp (40 lines)

Diff 46747

input.h

Loading...

input.cpp

Loading...

pointer_input.cpp

Loading...

touch_input.cpp

Loading...