Differential D15511

Add support for Code 128 barcodes
ClosedPublic
Actions

Authored by vkrause on Sep 14 2018, 5:17 PM.

Tags

Subscribers

kde-frameworks-devel

Details

Reviewers

Commits

R280:fa3f31329aea: Add support for Code 128 barcodes

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Sep 14 2018, 5:17 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptSep 14 2018, 5:17 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

vkrause requested review of this revision.Sep 14 2018, 5:17 PM

Harbormaster completed remote builds in B2857: Diff 41657.Sep 14 2018, 5:17 PM

vkrause added a reviewer: svuorela.Sep 14 2018, 5:18 PM

svuorela added inline comments.Sep 14 2018, 5:29 PM

autotests/CMakeLists.txt
26	copy/paste error ?
autotests/code128barcodetest.cpp
112	doesn't QCOMPARE automatically output both ?

Remove copy/paste mistake.

Harbormaster completed remote builds in B2858: Diff 41659.Sep 14 2018, 5:32 PM

vkrause added inline comments.Sep 14 2018, 5:33 PM

autotests/code128barcodetest.cpp
112	Yep, but not perfectly aligned underneath each other, which is extremely helpful for spotting bit differences.

svuorela accepted this revision.Sep 14 2018, 5:42 PM

This revision is now accepted and ready to land.Sep 14 2018, 5:42 PM

Closed by commit R280:fa3f31329aea: Add support for Code 128 barcodes (authored by vkrause). · Explain WhySep 15 2018, 9:07 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/CMakeLists.txt (9 lines)
A	M		autotests/code128barcodetest.cpp (118 lines)
M			src/lib/CMakeLists.txt (1 line)
P			src/lib/code128barcode.h (57 lines) Copied from src/lib/prison.cpp
A	M		src/lib/code128barcode.cpp (356 lines)
M			src/lib/prison.h (6 lines)
P			src/lib/prison.cpp (3 lines) Copied to src/lib/code128barcode.h
M			tests/barcode.qml (2 lines)

Diff 41685

autotests/CMakeLists.txt

Loading...

autotests/code128barcodetest.cpp

Loading...

src/lib/CMakeLists.txt

Loading...

src/lib/code128barcode.h

Loading...

src/lib/code128barcode.cpp

Loading...

src/lib/prison.h

Loading...

src/lib/prison.cpp

Loading...

tests/barcode.qml

Loading...