Move everything KCrash related from Application to ApplicationX11
ClosedPublic

Authored by graesslin on May 6 2016, 2:31 PM.

Details

Summary

This change ensures that kwin_wayland does not pull in KCrash. We
don't want and need KCrash in the Wayland case. If KWin crashes the
session goes down - restarting doesn't make any sense, we need to
relogin.

Similar drkonqi just doesn't work as it doesn't have a windowing
system to connect to. After all the windowing system just crashed.

Also the AlternativeWM dialog doesn't make any sense on Wayland.
Similar thought: there is no windowing system to show this nice dialog.

Overall it's better to have system default behavior
(e.g. systemd-coredump) than using KCrash in the very special case of
kwin_wayland.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 3677.May 6 2016, 2:31 PM
graesslin retitled this revision from to Move everything KCrash related from Application to ApplicationX11.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 6 2016, 2:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah accepted this revision.May 9 2016, 5:09 AM
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.May 9 2016, 5:09 AM
This revision was automatically updated to reflect the committed changes.