[Bookmarks Runner] Remove BuildQuery Functor class
ClosedPublic

Authored by bruns on Sep 13 2018, 8:53 PM.

Details

Summary

Instead of constructing the query string on each favicon fetch just use
the (fixed) sql query string.

Test Plan

make
Switch default "Web browser" in Applications to Chrome/Chromium
Query bookmark with krunner, or e.g.
qdbus-qt5 org.kde.krunner /App org.kde.krunner.App.querySingleRunner bookmarks Phabricator

Diff Detail

Repository
R120 Plasma Workspace
Branch
simplify_query
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2829
Build 2847: arc lint + arc unit
bruns created this revision.Sep 13 2018, 8:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 13 2018, 8:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Sep 13 2018, 8:53 PM
davidedmundson accepted this revision.Sep 13 2018, 9:21 PM
This revision is now accepted and ready to land.Sep 13 2018, 9:21 PM
bruns edited the test plan for this revision. (Show Details)Sep 13 2018, 9:34 PM
This revision was automatically updated to reflect the committed changes.