disable the sorting for single album. does not make any sense, does not work. seems to have sneaked in during refactoring of the views
also override the sorting method for the album proxy model to be safe
Details
Details
- Reviewers
mgallien - Commits
- R255:8cef7f767248: disable sorting for single album view
no sorting button appears when viewing a single album
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/models/singlealbumproxymodel.cpp | ||
|---|---|---|
| 119–122 ↗ | (On Diff #41574) | Please remove this. Somebody reading this code will not understand why it could be empty. |
Comment Actions
I removed the override.
| src/models/singlealbumproxymodel.cpp | ||
|---|---|---|
| 119–122 ↗ | (On Diff #41574) | One could argue that an album should always be displayed in its correct order, but anyway, all sort options currently clash with the way the multi disc albums are handled. The labels (e.g. CD1, CD2) will be displayed somewhere in the middle, which is nonsense. |