Differential D15485

Paint code folding marker only for multiline code folding regions
ClosedPublic
Actions

Authored by dhaumann on Sep 13 2018, 6:33 PM.

Details

Reviewers
cullmann
Commits
R39:6a35a902c969: Paint code folding marker only for multiline code folding regions
Summary

Before, a XML line like <bla> ... </bla> on the same line
resulted in a painted code folding marker. This patch only
paints the code folding marker, if the code folding region spans
multiple lines.

Without patch:

With patch:

Question is, whether there are corner cases where this patch is wrong?

Test Plan

make && make test

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Sep 13 2018, 6:33 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 13 2018, 6:33 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Sep 13 2018, 6:33 PM
dhaumann edited the summary of this revision. (Show Details)Sep 13 2018, 6:37 PM

Btw, this is a regression from the switch to the KSyntaxHighlighting framework. Maybe there is a better fix?

cullmann added a comment.Sep 13 2018, 6:58 PM

The hash update in katehighlight.cpp is the issue, Dominik has a fix for that now ;)

dhaumann updated this revision to Diff 41569.Sep 13 2018, 7:01 PM

Correct patch as discussed

cullmann accepted this revision.Sep 13 2018, 7:02 PM

+1 ;=)

My fault during porting :P

This revision is now accepted and ready to land.Sep 13 2018, 7:02 PM
Closed by commit R39:6a35a902c969: Paint code folding marker only for multiline code folding regions (authored by dhaumann). · Explain WhySep 13 2018, 7:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/syntax/katehighlight.cpp (2 lines)

Diff 41571

View Options

src/syntax/katehighlight.cpp

Loading...