Differential D15484

add margins for playing indicator
ClosedPublic
Actions

Authored by astippich on Sep 13 2018, 5:54 PM.

Details

Reviewers
mgallien
januz
Commits
R255:accdf96f9f55: add margins for playing indicator
Summary

add margin for the playing indicator again

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Sep 13 2018, 5:54 PM
astippich created this revision.
astippich added a comment.Sep 13 2018, 5:55 PM

Before

After

mgallien requested changes to this revision.Sep 13 2018, 7:35 PM

The different titles are no longer aligned. Please fix that. It is important that the album title is aligned with tracks title.

This revision now requires changes to proceed.Sep 13 2018, 7:35 PM
astippich updated this revision to Diff 41579.Sep 13 2018, 8:12 PM
  • restore previous behavior of album cover margins again
astippich retitled this revision from simplify and add margins for playlist entry to add margins for playing indicator.Sep 13 2018, 8:13 PM
astippich edited the summary of this revision. (Show Details)
In D15484#325459, @mgallien wrote:

The different titles are no longer aligned. Please fix that. It is important that the album title is aligned with tracks title.

well, I think the missing margin on the album cover actually looks worse, but I restored the behavior and just added the margin for the playing indicator

mgallien accepted this revision.Sep 14 2018, 5:18 AM
This revision is now accepted and ready to land.Sep 14 2018, 5:18 AM
Closed by commit R255:accdf96f9f55: add margins for playing indicator (authored by astippich). · Explain WhySep 17 2018, 5:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/PlayListEntry.qml (6 lines)

Diff 41857

View Options

src/qml/PlayListEntry.qml

Loading...