Differential D15474

[effects/fadedesktop] Set animation as a fullscreen effect
ClosedPublic
Actions

Authored by davidedmundson on Sep 13 2018, 10:09 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:b1b1360ec3fb: [effects/fadedesktop] Set animation as a fullscreen effect
Summary

This lets other effects know whether they should inhibit or not which reduces
visual glitches of overlapping animations.

BUG: 321201
FIXED-IN: 5.15.0

Test Plan

Switched desktops, they still faded

Diff Detail

Repository
R108 KWin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2791
Build 2809: arc lint + arc unit
Restricted Application added a project: KWin. · View Herald TranscriptSep 13 2018, 10:09 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Sep 13 2018, 10:09 AM
zzag added a subscriber: zzag.Sep 13 2018, 10:46 AM

I didn't test this patch but I'm pretty sure we have to "force" WindowForceBackgroundContrastRole and WindowForceBlurRole.

davidedmundson updated this revision to Diff 41543.Sep 13 2018, 12:58 PM

Force blur/constrast to stay on even though we're a full screen effect

zzag requested changes to this revision.EditedOct 4 2018, 7:11 AM

It doesn't completely fix visual glitches when switching virtual desktops with the desktop cube.

This revision now requires changes to proceed.Oct 4 2018, 7:11 AM
davidedmundson added a comment.Oct 4 2018, 12:25 PM

It doesn't completely fix visual glitches when switching virtual desktops with the desktop cube.

I'm confused, if you're switching desktops with the cube, how would you have the fade desktop effect as well? They're radio buttons

zzag added a comment.Oct 4 2018, 12:27 PM
In D15474#336440, @davidedmundson wrote:

I'm confused, if you're switching desktops with the cube, how would you have the fade desktop effect as well? They're radio buttons

Not that cube. Press Ctrl+F11, for example (make sure the Desktop Cube effect is enabled)

zzag added inline comments.Oct 10 2018, 9:37 AM
effects/fadedesktop/package/contents/code/main.js
29

We should check active full screen effect:

if (effects.hasActiveFullScreenEffect && !effect.isActiveFullScreenEffect) {
    return;
}
zzag edited the summary of this revision. (Show Details)Oct 10 2018, 9:38 AM
davidedmundson updated this revision to Diff 43289.Oct 10 2018, 10:59 AM

Don't start fullscreen effect if one is active

zzag accepted this revision.Oct 10 2018, 11:05 AM
This revision is now accepted and ready to land.Oct 10 2018, 11:05 AM
Closed by commit R108:b1b1360ec3fb: [effects/fadedesktop] Set animation as a fullscreen effect (authored by davidedmundson). · Explain WhyOct 10 2018, 11:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41525

View Options

effects/fadedesktop/package/contents/code/main.js

Loading...