Differential D15462

Do ignore-filtered-siblings properly
ClosedPublic
Actions

Authored by hein on Sep 12 2018, 6:23 PM.

Details

Reviewers
davidedmundson
Commits
R120:c81205cc458e: Do ignore-filtered-siblings properly
Summary

Turns out c8358c203f11 only worked accidentally. We can't do this
via filterModel->mapFromSource, because in a lambda connected to
its source model's rowsInserted signal, the proxy hasn't seen that
row yet.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Sep 12 2018, 6:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 12 2018, 6:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein requested review of this revision.Sep 12 2018, 6:23 PM
davidedmundson accepted this revision.Sep 12 2018, 6:29 PM
This revision is now accepted and ready to land.Sep 12 2018, 6:29 PM
Closed by commit R120:c81205cc458e: Do ignore-filtered-siblings properly (authored by hein). · Explain WhySep 12 2018, 6:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41500

View Options

libtaskmanager/taskfilterproxymodel.h

Loading...
View Options

libtaskmanager/taskfilterproxymodel.cpp

Loading...
View Options

libtaskmanager/tasksmodel.cpp

Loading...