makes data classes be implicitely shared: decrease memory usage
ClosedPublic

Authored by mgallien on Sep 12 2018, 3:42 PM.

Details

Summary

use QSharedDataPointer to implictely share the data classes
(MusicAudioTrack, MusicAlbum and MusicAudioGenre)

A little reduction n memory usage is measurable (at least on my setup).

A further optimization could be to only create a track once in
DatabaseInterface.

CCBUG: 396840

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Sep 12 2018, 3:42 PM
mgallien created this revision.
mgallien edited the summary of this revision. (Show Details)Sep 12 2018, 3:45 PM
mgallien added a project: Elisa.
mgallien added reviewers: astippich, januz, ognarb.
mgallien updated this revision to Diff 41572.Sep 13 2018, 7:10 PM

rebase on top of 0.3 branch

astippich accepted this revision.Sep 17 2018, 8:03 PM

I cannot really comment on the technical side of things as I am unfamiliar with it, so only tested as usual. Also a small reduction in memory usage here, and works fine.
You have again some changes for the theme file included which should not be here after rebase.

I would appreciate a review or a comment of my open revisions, some have been open for month without feedback.

This revision is now accepted and ready to land.Sep 17 2018, 8:03 PM
This revision was automatically updated to reflect the committed changes.