Differential D15455

Fix orientation when saving/transforming JPEG images
ClosedPublic
Actions

Authored by muhlenpfordt on Sep 12 2018, 3:14 PM.

Details

Reviewers
ngraham
Group Reviewers
Gwenview
Commits
R260:e6c60224defa: Fix orientation when saving/transforming JPEG images
Summary

6597d3f35196 introduced lossless JPEG transformations including a
reset of the Exif orientation tag before saving a JPEG image.
This leads to wrongly transformed images (modified or unmodified)
if the original JPEG already had an orientation tag with a visible
transformation (not None or Normal).
This is fixed by not resetting the orientation before saving, which
keeps the original JPEG data including orientation. Only before
executing a lossless transformation the Exif orientation correction
is applied and the tag is reset.

FIXED-IN: 18.08.2

Test Plan
  • Open JPEG image with Exif orientation other than None/Normal
  • Optional: Rotate/Mirror image
  • File → Save or File → Save As
  • Restart Gwenview to clear image cache
  • The new image should have the correct orientation

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
muhlenpfordt created this revision.Sep 12 2018, 3:14 PM
Restricted Application added a project: Gwenview. · View Herald TranscriptSep 12 2018, 3:14 PM
muhlenpfordt requested review of this revision.Sep 12 2018, 3:14 PM
muhlenpfordt added a comment.Sep 12 2018, 3:37 PM

I noticed this bug report but can't confirm a change in JPEG quality or file size when saving (as the original reporter stated).
ATM the transformation is not done by just changing the Exif orientation as Christoph suggested, but by lossless data transformation.
So I think this patch does not really fix that bug.

muhlenpfordt added a comment.Sep 12 2018, 5:56 PM
In D15455#324709, @ngraham wrote:

On another note, did 6597d3f35196 fix https://bugs.kde.org/show_bug.cgi?id=324597 and/or https://bugs.kde.org/show_bug.cgi?id=278661?

Ah, sorry - did not read your question correctly.
I can't confirm any of these bugs with current Gwenview versions - maybe the first one was fixed by this commit but the second is not for JPG files.
Besides the commit is older than both bug reports.

muhlenpfordt updated this revision to Diff 41880.Sep 18 2018, 7:18 AM

Added comment and grouping

muhlenpfordt added a comment.Sep 18 2018, 7:19 AM

If there are no objections I'll commit this at end of the week.

ngraham accepted this revision.Sep 18 2018, 1:57 PM
ngraham added a subscriber: rkflx.

Sorry for the extended review time. It's just not the same since @rkflx left :(

This revision is now accepted and ready to land.Sep 18 2018, 1:57 PM
Closed by commit R260:e6c60224defa: Fix orientation when saving/transforming JPEG images (authored by muhlenpfordt). · Explain WhySep 21 2018, 6:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42026

View Options

lib/document/jpegdocumentloadedimpl.cpp

Loading...