Differential D15446

Fix djvu build on macos
ClosedPublic
Actions

Authored by arichardson on Sep 12 2018, 8:36 AM.

Details

Reviewers
vonreth
Commits
R877:2b6289dc21b3: Fix djvu build on macos
Summary

Build using autotools on non-Windows systems since that is the supported way.

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arichardson requested review of this revision.Sep 12 2018, 8:36 AM
arichardson created this revision.
arichardson added a comment.Sep 12 2018, 8:38 AM

I found https://github.com/acmepjz/djvulibre with cmake build system, should we be using that instead?

vonreth added a comment.Sep 12 2018, 10:05 AM

Hm I'm not a big fan of downstream build systems in general ( we had issues with it before) if the one you found is better maintained and offers similar platform support and the same lib names we might want to switch. Or we use the native build system where possible...

arichardson added a comment.Sep 12 2018, 10:06 AM

I guess the other option is to just use the autotools build for linux/mac?

vonreth added a comment.Sep 12 2018, 11:26 AM

Hm yes autotools is at least tested with the software.
I hate it but if it's the supported way to build it....

arichardson updated this revision to Diff 41530.Sep 13 2018, 10:48 AM
arichardson edited the summary of this revision. (Show Details)

Build using autotools on non-Windows systems since that is the supported way.

arichardson updated this revision to Diff 41531.Sep 13 2018, 10:49 AM

Add missing newline

vonreth accepted this revision.Sep 13 2018, 10:59 AM

Looks good

This revision is now accepted and ready to land.Sep 13 2018, 10:59 AM
Closed by commit R877:2b6289dc21b3: Fix djvu build on macos (authored by arichardson). · Explain WhySep 13 2018, 12:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41541

View Options

libs/djvu/djvu.py

Loading...
View Options

libs/djvu/djvulibre-3.5.27-20151208.diff

Loading...