Differential D15442

Improve DDCUtil handling in CMakeLists
Needs ReviewPublic
Actions

Authored by nilathak on Sep 12 2018, 12:36 AM.

Details

Reviewers
broulik
dvogel
Summary

This has already been started in https://phabricator.kde.org/D8626?id=33105
but never got merged.
Whenever ddcutil is present during build, it should be OK to enable the support by default.
It can still be turned off via CMAKE_DISABLE_FIND_PACKAGE_DDCUtil=ON.

This will also provide a better fix for https://bugs.gentoo.org/636098

Diff Detail

Repository
R122 Powerdevil
Lint
Lint Skipped
Unit
Unit Tests Skipped
nilathak created this revision.Sep 12 2018, 12:36 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 12 2018, 12:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nilathak requested review of this revision.Sep 12 2018, 12:36 AM
krop added a subscriber: krop.Sep 12 2018, 10:30 AM

With the change, you can't tell if powerdevil must use the old or the new api. Suggestion: https://paste.kde.org/powk2bhxm

config_powerdevil.h then defines HAVE_DDCUTIL and DDCUTIL_VERSION

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (19 lines)

Diff 41444

View Options

CMakeLists.txt

Loading...