Add translucent background attribute to desktop icon popup menu
ClosedPublic
Actions

Authored by anemeth on Sep 11 2018, 7:35 PM.

Details

Reviewers

hein
davidedmundson

Group Reviewers

Plasma

Commits

R119:cc47b95094a3: Add translucent background attribute to desktop icon popup menu

Summary

This fixes the issue when menu transparency is enabled in the Breeze widget settings the context menu of desktop icons have no transparency.
Multiple users (including me) have reported that D14174 did not solve the problem.

BUG: 395262

Test Plan

Before:

After:

Diff Detail

Repository

R119 Plasma Desktop

Branch

fix_desktop_menu_tp

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 2733
Build 2751: arc lint + arc unit

anemeth created this revision.Sep 11 2018, 7:35 PM

Restricted Application added a project: Plasma. · View Herald TranscriptSep 11 2018, 7:35 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

anemeth requested review of this revision.Sep 11 2018, 7:35 PM

Harbormaster completed remote builds in B2733: Diff 41431.Sep 11 2018, 7:35 PM

Add translucent background attribute to popup menu

Harbormaster completed remote builds in B2734: Diff 41432.Sep 11 2018, 7:36 PM

anemeth edited the summary of this revision. (Show Details)Sep 11 2018, 7:42 PM

anemeth edited the test plan for this revision. (Show Details)

anemeth added reviewers: hein, davidedmundson, Plasma.

anemeth edited the summary of this revision. (Show Details)

anemeth added a subscriber: ngraham.Sep 11 2018, 7:49 PM

davidedmundson accepted this revision.Sep 11 2018, 8:42 PM

This revision is now accepted and ready to land.Sep 11 2018, 8:42 PM

anemeth retitled this revision from Add translucent background attribute to popup menu to Add translucent background attribute to desktop icon popup menu.Sep 11 2018, 8:46 PM

I'm having problems with my arcanist.
Could someone please land this for me?

Closed by commit R119:cc47b95094a3: Add translucent background attribute to desktop icon popup menu (authored by anemeth, committed by asturmlechner). · Explain WhySep 12 2018, 9:50 PM

This revision was automatically updated to reflect the committed changes.

anemeth mentioned this in D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.Feb 6 2019, 10:03 PM

Revision Contents
Changeset List

			Path	Packages
M			containments/desktop/plugins/folder/foldermodel.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41431	45c420b		Sep 11 2018, 7:35 PM	★	★
Diff 2	41432	45c420b	Add translucent background attribute to popup menu	Sep 11 2018, 7:36 PM	★	★
Diff 3	41509	a4c7241	R119:cc47b95094a331fe5bdd38f340d549dfa1bbf507	Sep 12 2018, 9:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4f2f56f5897a	686b60403071	45c420b7fd11	Alex Nemeth	Add translucent background attribute to popup menu	Sep 11 2018, 7:32 PM

Diff 41431

View Options

containments/desktop/plugins/folder/foldermodel.cpp