Differential D15429

Simplify cmake code: link to Qt5::GuiPrivate.
ClosedPublic
Actions

Authored by dfaure on Sep 11 2018, 1:45 PM.

Details

Reviewers
kfunk
kossebau
broulik
Commits
R135:db3a865c8cbf: Simplify cmake code: link to Qt5::GuiPrivate.
Summary

This target was added in Qt 5.9, which we can now rely upon.
Also use target_include_directories rather than the big
include_directories hammer.

Test Plan

Compiles

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Sep 11 2018, 1:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 11 2018, 1:45 PM
Restricted Application edited subscribers, added: plasma-devel; removed: Plasma. · View Herald Transcript
dfaure requested review of this revision.Sep 11 2018, 1:45 PM
kfunk accepted this revision.Sep 11 2018, 1:46 PM

I think that makes sense. +1.

This revision is now accepted and ready to land.Sep 11 2018, 1:46 PM
broulik accepted this revision.Sep 11 2018, 7:28 PM
kossebau added a comment.Sep 28 2018, 10:22 AM

@dfaure: Was this one pushed already? If not, target would be now Plasma/5.14 branch, with 5.13 EOL

dfaure added a comment.Sep 28 2018, 4:29 PM

I completely forgot about pushing it, thanks for the reminder and for the target branch information.

Closed by commit R135:db3a865c8cbf: Simplify cmake code: link to Qt5::GuiPrivate. (authored by dfaure). · Explain WhySep 28 2018, 4:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42501

View Options

CMakeLists.txt

Loading...
View Options

autotests/CMakeLists.txt

Loading...
View Options

src/platformtheme/CMakeLists.txt

Loading...