Differential D15424

[effects/showpaint] Modernize code
ClosedPublic
Actions

Authored by zzag on Sep 11 2018, 1:00 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:cc1f30b43d16: [effects/showpaint] Modernize code
Summary

Summary of changes:

  • Use QVector to store colors
  • Add Q_OBJECT macro
  • Port away from QRegion::rects
  • Fix coding style
  • Use default member initialization
  • Use nullptr
  • Reserve rects in paintXrender

The behavior of this effect haven't been changed, it still acts as before.

Test Plan

Compiles, and the Show Paint effect is still a psychedelic thing.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Sep 11 2018, 1:00 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 11 2018, 1:00 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 11 2018, 1:00 PM
zzag updated this revision to Diff 41403.Sep 11 2018, 1:06 PM

Constify alpha in paintXrender

zzag updated this revision to Diff 41404.Sep 11 2018, 1:10 PM

Add alpha const

davidedmundson accepted this revision.Sep 11 2018, 1:18 PM
This revision is now accepted and ready to land.Sep 11 2018, 1:18 PM
Closed by commit R108:cc1f30b43d16: [effects/showpaint] Modernize code (authored by zzag). · Explain WhySep 11 2018, 2:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41412

View Options

effects/showpaint/showpaint.h

Loading...
View Options

effects/showpaint/showpaint.cpp

Loading...