Instead use new API that returns a buffer to avoid writing to the file system
Details
Details
- Reviewers
TheAssassin anthonyfieroni - Group Reviewers
Frameworks - Commits
- R320:ec93501d3318: [AppImage Thumbnailer] Avoid creating QTemporaryFile
Built libappimage with https://github.com/AppImage/libappimage/pull/9
Thumbnails are created just fine
Diff Detail
Diff Detail
- Repository
- R320 KIO Extras
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/CMakeLists.txt$10
It should be specified the version that contains appimage_read_file_into_buffer_following_symlinks
Comment Actions
Maybe it's better to make new code conditional to version that satisfy appimage_read_file_into_buffer_following_symlinks
Comment Actions
The AppImage project doesn't do any versioning right now. We've recently extracted libappimage into a separate project to be able to start versioning of it, as projects like KDE expect and somehow need that. We're discussing a suitable versioning scheme right now. Please feel free to participate in the discussion in https://github.com/AppImage/AppImageKit/issues/849, and add your point of view.