[effects/dialogparent] Fix strict mode issues
ClosedPublic

Authored by zzag on Sep 10 2018, 7:20 PM.

Details

Summary

Modification of undeclared variables is illegal in the strict mode, e.g.

mainWindows = window.mainWindows();

is illegal.

Test Plan

The Dialog Parent effect works with both QScriptEngine and QJSEngine.

Diff Detail

Repository
R108 KWin
Branch
effects-dialogparent-fix-strict-mode-issues
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2693
Build 2711: arc lint + arc unit
zzag created this revision.Sep 10 2018, 7:20 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 10 2018, 7:20 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 10 2018, 7:20 PM
davidedmundson accepted this revision.Sep 10 2018, 7:46 PM
This revision is now accepted and ready to land.Sep 10 2018, 7:46 PM
This revision was automatically updated to reflect the committed changes.