Change Style, Add Clarity, Rephrase Sentences
Needs ReviewPublic

Authored by abetts on Sep 10 2018, 3:45 AM.

Details

Reviewers
fabianr
ngraham
Summary

Added clarity to the HIG. Changed part of the look-and-feel

Test Plan

NA

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Branch
concepts (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3351
Build 3369: arc lint + arc unit
abetts requested review of this revision.Sep 10 2018, 3:45 AM
abetts created this revision.
ngraham requested changes to this revision.Sep 11 2018, 12:07 PM

Cool. I have one general formatting suggestion: please respect the soft per-line 80 character limit. Some of your edits make each line really long, and it's deliberate that lines be artificially limited to about 80 characters.

In addition, I have some specific comments below:

source/introduction/concept.rst
18

This change isn't grammatically correct. "All project stakeholders" is okay already, just a little terse. If you want to change this, it would need to become "all of the project's stakeholders".

61–62

"Like a motto." is a sentence fragment.

88–89

"that such persona" is not grammatically correct. "that your persona" or "that the persona" would work, though.

This revision now requires changes to proceed.Sep 11 2018, 12:07 PM
fabianr added inline comments.Sep 11 2018, 12:11 PM
source/introduction/concept.rst
77

Does that still exist kde-usability at kde.org ?

ngraham added inline comments.Sep 11 2018, 12:13 PM
source/introduction/concept.rst
77

Yeah, at this point VDG has taken over that role so we should direct people there instead.

abetts updated this revision to Diff 42581.Sep 30 2018, 4:54 AM

Address Word Choice

Comments still not addressed.