Differential D15391

[Bookmarks Runner] Fix cleanup of favicon directory
ClosedPublic
Actions

Authored by bruns on Sep 9 2018, 10:52 PM.

Details

Reviewers
davidedmundson
broulik
Group Reviewers
Plasma
Commits
R120:140b908e4c17: [Bookmarks Runner] Fix cleanup of favicon directory
Summary

QDir.entryInfoList(NoDotAndDotDot) always returns an empty list, as it
requires one of QDir::Files, QDir::Dirs or QDir::Drives or any
combination thereof.

Instead of implementing it manually, use QDir::removeRecursively().

Test Plan

Watch ~/.cache/krunner/
When krunner is closed, KRunner-Favicons-firefox-default should
be emptied and deleted.

Diff Detail

Repository
R120 Plasma Workspace
Branch
favicon_dir_cleanup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2664
Build 2682: arc lint + arc unit
bruns created this revision.Sep 9 2018, 10:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 9 2018, 10:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Sep 9 2018, 10:52 PM
broulik accepted this revision.Sep 10 2018, 6:44 AM
This revision is now accepted and ready to land.Sep 10 2018, 6:44 AM
Closed by commit R120:140b908e4c17: [Bookmarks Runner] Fix cleanup of favicon directory (authored by bruns). · Explain WhySep 10 2018, 12:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41300

View Options

runners/bookmarks/faviconfromblob.cpp

Loading...