Remove MimeType related code
ClosedPublic

Authored by tcanabrava on Sun, Sep 9, 3:53 PM.

Details

Summary

This is uneeded and we can create and use the mimetype
directly inside of the DetachableTabBar as nothing else
needs to know about it.

Test Plan

Compile and runs. Unused code.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Sun, Sep 9, 3:53 PM
Restricted Application added a project: Konsole. · View Herald TranscriptSun, Sep 9, 3:53 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Sun, Sep 9, 3:53 PM
tcanabrava edited the test plan for this revision. (Show Details)Sun, Sep 9, 4:14 PM

Does there need to be a followup change to add this back to DetachableTabBar as you mention in your summary?

Does there need to be a followup change to add this back to DetachableTabBar as you mention in your summary?

No, this is completely dead code and the new DetachableTabBar already deals with drag'n drop differently.

hindenburg accepted this revision.Mon, Sep 17, 2:26 PM

thanks

This revision is now accepted and ready to land.Mon, Sep 17, 2:26 PM
This revision was automatically updated to reflect the committed changes.