Remove MimeType related code
ClosedPublic
Actions

Authored by tcanabrava on Sep 9 2018, 3:53 PM.

Details

Reviewers

Commits

R319:209d43f9866a: Remove MimeType related code

Summary

This is uneeded and we can create and use the mimetype
directly inside of the DetachableTabBar as nothing else
needs to know about it.

Test Plan

Compile and runs. Unused code.

Repository

R319 Konsole

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: konsole-devel. · View Herald Transcript

tcanabrava requested review of this revision.Sep 9 2018, 3:53 PM

Does there need to be a followup change to add this back to DetachableTabBar as you mention in your summary?

In D15378#327161, @hindenburg wrote:

Does there need to be a followup change to add this back to DetachableTabBar as you mention in your summary?

No, this is completely dead code and the new DetachableTabBar already deals with drag'n drop differently.

thanks

This revision is now accepted and ready to land.Sep 17 2018, 2:26 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/ViewProperties.h (31 lines)
M			src/ViewProperties.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41268	ce28d6b		Sep 9 2018, 3:53 PM	★	★
Diff 2	41844	689723c	R319:209d43f9866aeb02b53922639a4d0e120e261669	Sep 17 2018, 2:27 PM	★	★