Differential D15356

[Bookmarks Runner] Filter out empty urls, simplify, fix comment
ClosedPublic
Actions

Authored by bruns on Sep 8 2018, 7:16 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:08895fd7f1ab: [Bookmarks Runner] Filter out empty urls, simplify, fix comment
Summary

Bookmarks may have no title, the user is free to delete it when creating
a bookmark.
A bookmark without URL would be useless (there were nothing to refer to),
so ignore any bookmark with an empty URL.
Simplify check for Firefox specific "place:" URLs.

Test Plan

Search for "Recent" or "place"
"Recent Tags" is still filtered out

Diff Detail

Repository
R120 Plasma Workspace
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2604
Build 2622: arc lint + arc unit
bruns created this revision.Sep 8 2018, 7:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 8 2018, 7:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Sep 8 2018, 7:16 PM
davidedmundson accepted this revision.Sep 8 2018, 8:12 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
runners/bookmarks/browsers/firefox.cpp
105

whilst we're at it

QLatin1String

This revision is now accepted and ready to land.Sep 8 2018, 8:12 PM
bruns updated this revision to Diff 41223.Sep 8 2018, 8:40 PM

replace QStringLiteral

Closed by commit R120:08895fd7f1ab: [Bookmarks Runner] Filter out empty urls, simplify, fix comment (authored by bruns). · Explain WhySep 8 2018, 8:49 PM
This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.

Revision Contents
Changeset List

Diff 41215

View Options

runners/bookmarks/browsers/firefox.cpp

Loading...