Move Breadcrumb and Sliderspin content to more appropriate places
ClosedPublic

Authored by ngraham on Sep 8 2018, 4:24 AM.

Details

Summary

Breadcrumbs is a navigation pattern, so it should be in the Navigation Patterns section, merged with the existing page there.

Slider and Spinbox is a simple conbination of two components, so it should be another variant on the existing Slider page.

Test Plan

make html then view everything locally.

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Branch
move-patterns-to-appropriate-places (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2621
Build 2639: arc lint + arc unit
ngraham requested review of this revision.Sep 8 2018, 4:24 AM
ngraham created this revision.
ngraham edited the summary of this revision. (Show Details)Sep 8 2018, 4:24 AM
ngraham edited the summary of this revision. (Show Details)
fabianr added a subscriber: fabianr.Sep 8 2018, 7:26 AM

Isn't a combination of multiple controls a pattern? Even if it's only two controls?

If we are moving it to components we probably should merge it with the existing page about the slider https://hig.kde.org/components/editing/slider.html (there is although already a dedicated page about https://hig.kde.org/components/editing/spinbox.html ). The slider page covers most of the content already.

ngraham planned changes to this revision.Sep 9 2018, 2:48 AM

Isn't a combination of multiple controls a pattern? Even if it's only two controls?

Well maybe, but the slider-and-spinbox combination doesn't amount to a content pattern. These are UI controls, not content. And it didn't really seem like a command or navigation pattern.

If we are moving it to components we probably should merge it with the existing page about the slider https://hig.kde.org/components/editing/slider.html (there is although already a dedicated page about https://hig.kde.org/components/editing/spinbox.html ). The slider page covers most of the content already.

All right, no problem!

ngraham updated this revision to Diff 41239.Sep 9 2018, 3:57 AM

Remove sliderspin page and combine its content with existing slider page

ngraham edited the summary of this revision. (Show Details)Sep 9 2018, 3:59 AM
fabianr accepted this revision.Sep 11 2018, 1:17 PM

Thank you very much. I'll update the Slider.Speed.qml.png to showcase a slider with a spinbox.

This revision is now accepted and ready to land.Sep 11 2018, 1:17 PM
ngraham closed this revision.Sep 11 2018, 2:55 PM