[Plasma Search KCM] Add a UI tab for editing shortcuts.
Needs ReviewPublic

Authored by smithjd on Sep 7 2018, 9:46 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Summary

Diff Detail

Repository
R119 Plasma Desktop
Branch
master-krunnerkeybindings (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12182
Build 12200: arc lint + arc unit
smithjd created this revision.Sep 7 2018, 9:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 7 2018, 9:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
smithjd requested review of this revision.Sep 7 2018, 9:46 PM
smithjd edited the summary of this revision. (Show Details)Sep 7 2018, 9:50 PM
ngraham requested changes to this revision.Sep 9 2018, 5:12 AM
ngraham added a subscriber: ngraham.

I appreciate the patch and the fact that you considered the prior comments in D14739. But I must admit I'm still left with a nagging question: "Why?"

Why here? Why not elsewhere? How about the search field in Kicker and Kickoff? The one in Dolphin? If this should be done at all, shouldn't it be done everywhere? And if it can't be done everywhere due to conflicts (i.e. because ctrl+a and ctrl+s have existing meanings in GUI software), then should it be done at all? It just seems sort of random to add this very heavyweight configuration UI here in the KCM to change shortcuts for KRunner that basically nobody but you would ever want to change. :) Pretty much the only KRunner-related shortcut that your average user might actually want to change in the KCM is the activation shortcut, and that's not here--though I would be happy to see a patch to add just that on the main page, without adding another tab. If we absolutely must add alternative hidden power user CLI-inspired navigation shortcuts to KRunner (which I'm not yet convinced on), let's just do it, and not wrap it in a whole bunch of user-visible configuration UI.

This revision now requires changes to proceed.Sep 9 2018, 5:12 AM

I appreciate the patch and the fact that you considered the prior comments in D14739. But I must admit I'm still left with a nagging question: "Why?"

Why here? Why not elsewhere? How about the search field in Kicker and Kickoff? The one in Dolphin? If this should be done at all, shouldn't it be done everywhere? And if it can't be done everywhere due to conflicts (i.e. because ctrl+a and ctrl+s have existing meanings in GUI software), then should it be done at all?

Kicker/Kickoff and the dolphin search aren't full-fledged launchers like KRunner, only search fields for Baloo.

It just seems sort of random to add this very heavyweight configuration UI here in the KCM to change shortcuts for KRunner that basically nobody but you would ever want to change. :) > Pretty much the only KRunner-related shortcut that your average user might actually want to change in the KCM is the activation shortcut, and that's not here--though I would be happy to > see a patch to add just that on the main page, without adding another tab. If we absolutely must add alternative hidden power user CLI-inspired navigation shortcuts to KRunner (which I'm > not yet convinced on), let's just do it, and not wrap it in a whole bunch of user-visible configuration UI.

Kicker/Kickoff and the dolphin search aren't full-fledged launchers like KRunner, only search fields for Baloo.

  1. Kicker/Kickoff actually are: they're full-fledged interfaces to KRunner, with the exception that they have a semi-hardcoded list of enabled runners.
  2. Not sure how that would make a difference anyway; the point is, if these navigation shortcuts are valuable for the KRunner input field, why wouldn't they be useful for every input field?

Kicker/Kickoff and the dolphin search aren't full-fledged launchers like KRunner, only search fields for Baloo.

  1. Kicker/Kickoff actually are: they're full-fledged interfaces to KRunner, with the exception that they have a semi-hardcoded list of enabled runners.
  2. Not sure how that would make a difference anyway; the point is, if these navigation shortcuts are valuable for the KRunner input field, why wouldn't they be useful for every input field?

KRunner as a standalone application does much more than search for files. Therefore adding independent shortcut configurability isn't so hard to justify. Kicker/Kickoff and dolphin search text input shortcuts on the other hand are configurable globally already, and only perform a subset of what KRunner does.

KRunner as a standalone application does much more than search for files. Therefore adding independent shortcut configurability isn't so hard to justify. Kicker/Kickoff and dolphin search text input shortcuts on the other hand are configurable globally already, and only perform a subset of what KRunner does.

Can you explain why the fact that KRunner does more than the search fields in Kicker/Kickoff and Dolphin is a justification for allowing you to customize a small subset of the navigation shortcuts there, but not elsewhere? Help me understand where you're coming from. If you'd want to use ctrl+e and ctrl+s (etc.) to navigate in KRunner, why wouldn't you want to use them elsewhere too? What's the difference?

KRunner as a standalone application does much more than search for files. Therefore adding independent shortcut configurability isn't so hard to justify. Kicker/Kickoff and dolphin search text input shortcuts on the other hand are configurable globally already, and only perform a subset of what KRunner does.

Can you explain why the fact that KRunner does more than the search fields in Kicker/Kickoff and Dolphin is a justification for allowing you to customize a small subset of the navigation shortcuts there, but not elsewhere? Help me understand where you're coming from. If you'd want to use ctrl+e and ctrl+s (etc.) to navigate in KRunner, why wouldn't you want to use them elsewhere too? What's the difference?

Global in-application shortcuts can already be customized. The problem is that often the desired shortcut is already assigned to some other action, such as Ctrl+S for saving across all applications. Reassigning Ctrl+S globally just for one application is terrible from a HIG perspective, so an application-specific override must be considered. A welcome side-effect from this is the large number of shortcuts now available to KRunner that don't impact global actions.

In KRunner a larger percentage of the functionality is derived of text input, Dolphin / Kicker / Kickoff aren't similar to bash / KRunner in this regard and so wouldn't benefit as much from configurable input navigation shortcuts. The global shortcuts will still have the same actions as other applications unless the global shortcut is used for a KRunner action.

IMO, this feature should already be a part of KRunner, though it hasn't had an outstanding absence. The notion that global shortcuts should be shuffled for a single application is wrong. Changing the global shortcut for the same type of input navigation may suit the user, though this shouldn't be encouraged for only a single application. Promoting global shortcuts over an application-specific configureability is always wrong, and less right when there's already a patch. :)

smithjd updated this revision to Diff 58698.May 27 2019, 1:40 AM
  • [Plasma Search KCM] Re-organize the tab and widget layouts.
  • Add edit actions.
smithjd edited the summary of this revision. (Show Details)May 27 2019, 1:44 AM

Instead of adding another tab, how about putting the shortcuts editor below the plugins list?