[Folder View] Hide /home/foo/Desktop place in configuration
ClosedPublic

Authored by broulik on Sep 7 2018, 1:24 PM.

Details

Summary

Folder View is meant to use desktop:/ and having two entries that behave differently can generate confusion.

CCBUG: 398141

Test Plan

There is no "Desktop" entry in places by default but I have seen many users add it

Existing configuration will instead show the path as custom url in the configuration

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 7 2018, 1:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 7 2018, 1:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 7 2018, 1:24 PM
ngraham added a subscriber: ngraham.Sep 7 2018, 2:15 PM

There is no "Desktop" entry in places by default but I have seen many users add it

Actually I added that in D11768. :)

broulik edited the test plan for this revision. (Show Details)Sep 7 2018, 2:17 PM
hein accepted this revision.Sep 7 2018, 6:04 PM
This revision is now accepted and ready to land.Sep 7 2018, 6:04 PM
hein added a comment.Sep 7 2018, 6:05 PM

Is it worth adding QQmlParserStatus to PlacesModel at this point?

It's just a QSortFilterProxyModel so not sure we can "delay" the filtering?

It's just a QSortFilterProxyModel so not sure we can "delay" the filtering?

setDynamicSortFilter on/off

broulik planned changes to this revision.Sep 8 2018, 4:14 PM

Alright, will look into QQmlParserStatus, didn't know about dynamicSortFilter

I just setDynamicSortFilter(false); in the constructor and setDynamicSortFilter(true); in QQmlParserStatus::componentComplete() but it doesn't make a difference.
The filterAcceptsRow() method is called the same number of times upon opening the config dialog with or without QQmlParserStatus

hein added a comment.Sep 10 2018, 10:35 AM

Let's not bother with it then, thanks for looking into it.

This revision was not accepted when it landed; it landed in state Changes Planned.Sep 10 2018, 11:04 AM
This revision was automatically updated to reflect the committed changes.