Fix the layout direction of 3 widgets
ClosedPublic

Authored by safaalfulaij on Sep 7 2018, 10:46 AM.

Details

Summary

Fix the layout direction of some settings widgets.
Forcing LeftToRight made the page left to right in right to left layouts.
Forcing RightToLeft made the checkbox's box to the right of the text instead of being to the left (in LTR
layouts).

Test Plan

Logic.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
safaalfulaij created this revision.Sep 7 2018, 10:46 AM
Restricted Application added a project: Krita. · View Herald TranscriptSep 7 2018, 10:46 AM
safaalfulaij requested review of this revision.Sep 7 2018, 10:46 AM

The label in the Image Properties dialog didn't really change at all.

The General Settings page:

LTR before:


LTR After*:

RTL before:

RTL after:

(*) I understand that it's maybe more nice to keep the box to the left of the spinbox. I think we need the expert here :) @ngraham
If they were several settings we could add something like “Enable Autosave” and have them under that, but this is only for one spinbox…

rempt accepted this revision.Sep 7 2018, 12:55 PM
rempt added a subscriber: rempt.

Hi! Thanks for these changes. Do you have push access?

This revision is now accepted and ready to land.Sep 7 2018, 12:55 PM

One way:

These are much nicer! Can we do it this way?

These are much nicer! Can we do it this way?

I also see that much nicer and, more important, consistent with the other checkboxes (on one column), but I think it's better if we merge this as is and I'll work on that on a seperate patch (and change the other checkboxes as well).

This revision was automatically updated to reflect the committed changes.