Differential D15305

KRunner: remove no longer existant and unused column from SQL query
ClosedPublic
Actions

Authored by bruns on Sep 6 2018, 1:57 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:99fa6ccc57c5: KRunner: remove no longer existant and unused column from SQL query
R120:cb99ab735c81: KRunner: remove no longer existant and unused column from SQL query
Summary

The favicon_id is not used in the query results, and may not even exist
when the places db has been created with FF 58 or later. In case the
column does not exist the query fails completely.

BUG: 398305

Test Plan
  1. Create a new FF profile
  2. Add some bookmarks
  3. Do some queries

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2547
Build 2565: arc lint + arc unit
bruns created this revision.Sep 6 2018, 1:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 6 2018, 1:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Sep 6 2018, 1:57 AM
davidedmundson accepted this revision.Sep 6 2018, 7:36 AM
This revision is now accepted and ready to land.Sep 6 2018, 7:36 AM
broulik added a subscriber: broulik.Sep 6 2018, 1:20 PM

Should this go into 5.12 branch as it's quite a common crasher we have there?

bruns added a comment.Sep 6 2018, 1:25 PM
In D15305#321346, @broulik wrote:

Should this go into 5.12 branch as it's quite a common crasher we have there?

Crash no, malfunction probably.

The schema depends on the first used FF version, FF removes old columns only after some time.

As the change is trivial, applying it to older branches is no big deal. How about 5.8? Do we expect to see FF 60 ESR on 5.8 LTS?

broulik added a comment.Sep 6 2018, 1:29 PM

Might have confused it with D10610

Closed by commit R120:cb99ab735c81: KRunner: remove no longer existant and unused column from SQL query (authored by bruns). · Explain WhySep 6 2018, 10:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41079

View Options

runners/bookmarks/browsers/firefox.cpp

Loading...