This patch ports the KCM to QQC2, which has the side effect of working around https://bugreports.qt.io/browse/QTBUG-70481 and improving the presentation for people using fractional Qt scale factors.
BUG: 397954
FIXED-IN: 5.16.0
Details
Details
- Reviewers
drosca - Group Reviewers
Plasma - Maniphest Tasks
- T7255: Audio Volume
- Commits
- R115:00026cee9ec8: [KCM] Port to QQC2
All functionality tested still worked. No visual changes at 1x scale. With a fractional scale factor, it now looks good:
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
There are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions
I'd prefer to port it completely to QQC2. As it is now, in some files you just changed Labels with QQC2 import and in others you changed QQC1->QQC2 import while there are also other QQC items.
Comment Actions
s/fix/work round/
Please use the commit message from one of the other patches that does this.
I repeatedly have to correct this meme spreading that QQC2 has any relevance to fractional scaling. It leads to other incorrect changes.
The only relevance is the text renderType which could be either on either QQC versions.
Our QQC2 desktop style happens to have a workaround.
Comment Actions
There is ScrollView in QQC2 (since Qt 5.9), so please use it.
Also as @davidedmundson said, please edit the commit message.
Comment Actions
Ah, I see now that it's only available in QQC 2.2 and later. Will do.
Also as @davidedmundson said, please edit the commit message.
The commit message from from the patch title, which is now [KCM] Port (almost) entirely to QQC2. Does that still need adjustment?
| src/kcm/package/contents/ui/CardListItem.qml | ||
|---|---|---|
| 32–33 | Plasma items should not be used in KCM. | |
Comment Actions
Plasma items should not be used in KCM.
Hmm, what you you recommend then for showing an icon item? The old QIconItem breaks for fractional scale factors. Kirigami has a nice icon, but then we'd need to import Kirigami.
| src/kcm/package/contents/ui/main.qml | ||
|---|---|---|
| 47 | I don't like them either, but the only way we can get rid of them without making the presentation really ugly is if we fix the bugs listed in the comments, or else stick with the QQC1 TabView. | |
Comment Actions
Thanks for the approval, but the scrollviews still don't actually scroll when the window is too small to fit all the content! I haven't been able to figure out why this is yet, so help would be appreciated if you have the time. :)
Comment Actions
Right, sorry.
So first, revert the change where I suggested to replace width binding with anchors.fill: parent, that's wrong.
Second, try to set ScrollView.contentWidth to width of ColumnLayout and same for the height.
Comment Actions
I don't really like that this port became full of workarounds to be honest, but if it works and there's no other way then fine.
Comment Actions
I understand and agree. We definitely need to fix https://bugs.kde.org/show_bug.cgi?id=394295 and https://bugs.kde.org/show_bug.cgi?id=394296 to make the QQC2 TabBar actually usable without all these client workarounds.
I'm okay with committing this now and removing the workarounds once those bugs are fixed, or waiting for those to get fixes first (provided it doesn't delay landing this patch forever). Your call.
Comment Actions
This is working and ready to land, but there's still an option question regarding whether we want to commit it now with the hacky workarounds for https://bugs.kde.org/show_bug.cgi?id=394296, or fix those first and remove the workarounds before committing.
Comment Actions
OK, I think this is finally ready to land. No more hacks. @drosca and/or @davidedmundson, could you confirm?
Comment Actions
What you're looking at was not touched in this patch. This patch only changed the category below it.