Compiles and still works.
- Group Reviewers
- R108:91ddeea7503f: [effects/coverswitch] Port to TimeLine
one set of parentheses seems redundant
it'll be a bigger refactor, but would it be more in line with Timeline to do .setDirection()
then we can kill all the
data.setOpacity(1.0 - timeLine.currentValue()); if (stop) data.setOpacity(timeLine.currentValue());
we should reset the timeline here
If animateStart is on and animateStop is off and a user cancels halfway through the load, we become inactive straight away and won't hit the main cleanup.
I know you've not touched this, but
should these two lines be wrapped in
&& timeLine.value < 0.5
should we not reset the timeline here?
Well, I didn't add them. Yeah, probably, that's okay to delete them.
Yes, it would be nice to just toggle direction. That's not really cool that effects call setCurrentTime/setElapsed(in fact, it's discouraged to call setElapsed).
Probably, we also have to reset start.
Probably, I also was wondering why opacity is ranging from -1 to 1.